----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25300/#review52193 -----------------------------------------------------------
Ship it! Ship It! - Joshua Cohen On Sept. 3, 2014, 4:02 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25300/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2014, 4:02 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-613 > https://issues.apache.org/jira/browse/AURORA-613 > > > Repository: aurora > > > Description > ------- > > This will be used by the job updater to gate insertion of JobUpdateEvents. > > I chose not to use StateMachine here as it actually added complexity - in > this case we don't benefit from transition callbacks, and the result is based > only on the target state (rather than the transition). > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25300/diff/ > > > Testing > ------- > > `./gradlew build -Pq` > > > Thanks, > > Bill Farner > >
