-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/#review52223
-----------------------------------------------------------



src/main/python/apache/thermos/core/runner.py
<https://reviews.apache.org/r/25175/#comment90965>

    This changes the return value from 0 to None upon timeout. Perhaps change 
'break' to 'return 0'?


- David Robinson


On Aug. 28, 2014, 11:34 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25175/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 11:34 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-669
>     https://issues.apache.org/jira/browse/AURORA-669
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix possible deadlock in TaskRunner.collect_updates.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/core/runner.py 
> ec4cdb788a1e24a590b262ba8dbd044cf31fc198 
> 
> Diff: https://reviews.apache.org/r/25175/diff/
> 
> 
> Testing
> -------
> 
> Regression test y/n ?
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Reply via email to