> On Sept. 2, 2014, 10:36 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java, > > line 35 > > <https://reviews.apache.org/r/24815/diff/1/?file=662758#file662758line35> > > > > Is this interface useful? The implementation logic is trivial, and > > it's only used from SchedulerThriftInterface. I suggest putting it there. > > Maxim Khutornenko wrote: > Right now that is correct. However, I'd expect JobUpdateController to > accept it in order to check quota any time an instance about to be added.
> in order to check quota any time an instance about to be added Is there a situation i'm not thinking of where that is needed rather than performing the quota check only once when first initiating the update? Is this because QuotaManager doesn't account for in-progress job udpates? - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24815/#review52089 ----------------------------------------------------------- On Aug. 18, 2014, 8:04 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24815/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2014, 8:04 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-94 > https://issues.apache.org/jira/browse/AURORA-94 > > > Repository: aurora > > > Description > ------- > > Moving the last bits of functionality out of SchedulerCore. > > Also, preparing the ground for task validation logic reuse in updater code. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/base/ScheduleException.java > e060e5ec88a0ab311415eaa638cf693c99c40049 > src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java > 62202810fd5829545fc77b91a20d1bb433a4916a > src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java > c636fd7fde8b592b167da8e5e9651ac772bc23de > src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java > 3dcb1c3e3d0138634b3d077c845ecc0d61d7fc0f > src/main/java/org/apache/aurora/scheduler/state/StateManager.java > 6e062b39175255264020bbb1cbd485de9a114a20 > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > 6ad104b050aabecad1dadc975c27d9d3603659bf > src/main/java/org/apache/aurora/scheduler/state/StateModule.java > cc1eee4e19c092c0d401558ac01b54627f2d1290 > src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 7ef28858ad290c74248b89c49d2a684eb1c7127e > > src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java > c7ae7db16e82c722fae1bccb9178f5ec203e91e5 > src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java > 62dce07b42af02d25b788e763e4e2a026dd2d483 > > src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java > fa611a913bad40a8c0515c578b394c460340e574 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > 1678411ad5c25e74f8bbbbb6d004bf491ea26ca0 > src/test/java/org/apache/aurora/scheduler/state/TaskLimitValidatorTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageSchedulerCoreImplTest.java > 35bed104d838596abcbb5abd5cad29592b384dfa > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 649afa24b2cfc9a1d67d350473e439d209bd720c > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > 43265fdab1ae900fb828374f6c69e562def2d682 > > Diff: https://reviews.apache.org/r/24815/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > >
