-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25366/#review52371
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/DriverFactory.java
<https://reviews.apache.org/r/25366/#comment91136>

    properties.getProperty() rather than properties.get(...).toString()
    
    Also, given that we're getting this multiple times (above for the log, 
below for the Credential), might make sense to just get it once and reuse 
(though the above is just a get call, not sure if there's any downside there to 
the implicit string conversion done by getProperty).


- Joshua Cohen


On Sept. 4, 2014, 11:16 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25366/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 11:16 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, 
> and Bill Farner.
> 
> 
> Bugs: AURORA-687
>     https://issues.apache.org/jira/browse/AURORA-687
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Set principal field in FrameworkInfo struct.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
> 9cc04a84a37374ffca418e2ff767992ee23b9f3e 
> 
> Diff: https://reviews.apache.org/r/25366/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to