----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24915/#review52376 -----------------------------------------------------------
Ship it! LGTM overall. src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java <https://reviews.apache.org/r/24915/#comment91149> Shouldn't this be == EXECUTOR_GC_INTERVAL to minimize the side-effects of a failover? As-is, you'll have a 15 minute period with 4x elevated GC runs. If so, this arg could collapse, and the new GcExecutorSettings method can go away. src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java <https://reviews.apache.org/r/24915/#comment91148> Please wrap this with Collections.synchronizedMap to preserve thread safety. - Bill Farner On Aug. 20, 2014, 11:35 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24915/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 11:35 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-608 > https://issues.apache.org/jira/browse/AURORA-608 > > > Repository: aurora > > > Description > ------- > > Adding initial GC task delay on scheduler restart. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > 5a38a1f69ac5dbe68af3bfe175899ddee392880b > src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java > 65f404915bc60ffe11a7a57d9861ac5b37fa646a > src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java > 04137072891b2a1f0ad663182629dd469b09324f > > Diff: https://reviews.apache.org/r/24915/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > >
