-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25450/
-----------------------------------------------------------

(Updated Sept. 9, 2014, 3:43 p.m.)


Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Changes
-------

Fixed time delay in test runs;
Adjusted logging output.


Bugs: aurora-5860
    https://issues.apache.org/jira/browse/aurora-5860


Repository: aurora


Description
-------

At some point, the "large update" warning logic was revised so that the
warning shows whenever you do an update that either:
- the updated config had more than 4x as many instances as the running one; or
- the updated config had less than 4x as many instances as the running one.

(Seriously: either local >= 4 * remote or local <= 4 * remote". And running git 
blame says it's all my fault.)

This fixes it: the correct logic is:
- the updated config has more than 4x as many as running; or
- the updated config has less than 1/4th as many as running.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/main/python/apache/aurora/client/cli/jobs.py 
8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
  src/test/python/apache/aurora/client/cli/test_update.py 
8b7d11202b35deb09a0000248cfe0a96458fb70c 
  src/test/python/apache/aurora/client/cli/util.py 
95a2123e127c9811fd2305e71cfc5c7c4376f904 

Diff: https://reviews.apache.org/r/25450/diff/


Testing
-------

Added new unit tests.


Thanks,

Mark Chu-Carroll

Reply via email to