----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25593/#review53220 -----------------------------------------------------------
Ship it! lgtm src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java <https://reviews.apache.org/r/25593/#comment92730> Obviously not related, but should these all use Objects.requireNonNull instead of Preconditions.checkNotNull? - Joshua Cohen On Sept. 12, 2014, 9:28 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25593/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 9:28 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Repository: aurora > > > Description > ------- > > This paves the way for ShiroWebModule integration. As an added benefit Guice > is now instantiating our servlets for us (no injector.getInstance calls in > our code). > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 9d8654b4268a13fc9d29d12f8da2c1aa8fda4b2b > > Diff: https://reviews.apache.org/r/25593/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > No new tests added - the existing JerseyServletModuleTests already cover > correctness of wiring. > > > Thanks, > > Kevin Sweeney > >
