-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25593/#review53226
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On Sept. 12, 2014, 9:43 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25593/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2014, 9:43 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This paves the way for ShiroWebModule integration. As an added benefit Guice 
> is now instantiating our servlets for us (no injector.getInstance calls in 
> our code).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 9d8654b4268a13fc9d29d12f8da2c1aa8fda4b2b 
> 
> Diff: https://reviews.apache.org/r/25593/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> No new tests added - the existing JerseyServletModuleTests already cover 
> correctness of wiring.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to