> On Sept. 12, 2014, 11:04 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java, 
> > line 102
> > <https://reviews.apache.org/r/25459/diff/3/?file=683405#file683405line102>
> >
> >     You mean inclusive?

Not really. Neither 0 nor max value makes sense in case of update. That, 
however, does not address the createJob case where max value would be legit.


> On Sept. 12, 2014, 11:04 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java, 
> > line 110
> > <https://reviews.apache.org/r/25459/diff/3/?file=683405#file683405line110>
> >
> >     This treats the update as though it is purely additive.  e.g. if i'm 
> > updating my job, i'm charged for 2x that job's resources.
> >     
> >     I believe the algorithm we'll need to use is max(before_update, 
> > after_update) when determining the impact of an update.
> >     
> >     The trouble here becomes visibility, we need to do some follow-up UI 
> > work so users aren't baffled when they're being charged for a paused update.

Thanks for catching this. It's hard to reason about this logic given 3 
different use cases (create, add, update). Need to refactor it a bit deeper to 
properly address all of them.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25459/#review53238
-----------------------------------------------------------


On Sept. 9, 2014, 12:30 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25459/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 12:30 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-649
>     https://issues.apache.org/jira/browse/AURORA-649
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Wiring TaskLimitValidator into the startJobUpdate API.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  3661f8487985f631e3ea437fe6430e0296376a9e 
>   src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 
> 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  a43e5d7748c22d60f56f03a8a3d52949faebeff2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskLimitValidatorTest.java 
> 8f18617b2052201f87bb1464314c2ee45b279276 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  0d51f7dc367081f72090736e36605bf363f3395e 
> 
> Diff: https://reviews.apache.org/r/25459/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to