> On Sept. 16, 2014, 8:49 p.m., David McLaughlin wrote:
> > services.js in the commit I shipped today has two references to 
> > INSTANCES_SKIPPED.
> 
> Bill Farner wrote:
>     Aha, you saw the writing on the wall and snuck in :-P

:) I'm fine with you just punting on changing them and leaving them for later 
when we add the second part of this... but they are also really easy references 
to remove.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25710/#review53585
-----------------------------------------------------------


On Sept. 16, 2014, 8:55 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25710/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 8:55 p.m.)
> 
> 
> Review request for Aurora and David McLaughlin.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Didn't see any reference in the UI code yet, so looks like this is a 
> thrift-only change.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> c80146aa3829e3c3102645a1864dbeaf5e2e56bc 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> e7770e651596a58b39138aadc240c45aaeb4230a 
> 
> Diff: https://reviews.apache.org/r/25710/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to