----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25760/#review53786 -----------------------------------------------------------
Ship it! LGTM mod Maxim's comments. - Bill Farner On Sept. 18, 2014, 12:20 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25760/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 12:20 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-722 > https://issues.apache.org/jira/browse/AURORA-722 > > > Repository: aurora > > > Description > ------- > > * Deflate snapshots using stream API > * Make LogManager non-final > > > Diffs > ----- > > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java > da4f0e5520f85782bbc246752cde29bd279be466 > src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java > 1eca768a7daf6defd4bb35a5c46e9c0eab370d92 > src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java > 0b59043cf5f01c99d09168d7669f51b686d2e930 > src/test/java/org/apache/aurora/codec/ThriftBinaryCodecTest.java > 7aaab1e7debbfed65ac7c15154ec73fc9f2114af > > Diff: https://reviews.apache.org/r/25760/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > The StreamManager @Timed annotations don't work yet since guice isn't used to > instantiate it. Ideally we'd use AssistedInject here, but that's a slightly > larger change. > > > Thanks, > > Kevin Sweeney > >
