> On Sept. 18, 2014, 8:42 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
> >  line 447
> > <https://reviews.apache.org/r/25791/diff/1/?file=693860#file693860line447>
> >
> >     Do we have any sort of guidelines on using Preconditions.checkNotNull 
> > vs Objects.requireNonNull, or should it always be the latter?

Yes, we should not be using Preconditions.checkNotNull.  Fixed, thanks!


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25791/#review53867
-----------------------------------------------------------


On Sept. 18, 2014, 8:14 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25791/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 8:14 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-613
>     https://issues.apache.org/jira/browse/AURORA-613
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> A follow-up change will scope the updaters to actionable instance changes, 
> which will remove the redundant actions being saved (see TODOs).
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  33bf7c7e6eeb538cf14fb3b9e58ae058390f7e05 
>   src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java 
> d9e59b6c1270f70235c4d0c38a8df7ce70499768 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 0e15a79ae6dc877dfa6ba492efafdf1f89f7d40f 
> 
> Diff: https://reviews.apache.org/r/25791/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to