-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25831/#review53969
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java
<https://reviews.apache.org/r/25831/#comment93853>

    Can you add a sentence explaining why the token might be absent?


- Bill Farner


On Sept. 19, 2014, 4:45 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25831/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 4:45 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Refactored saveJobUpdate API to allow for null lock token (possible during 
> snapshot restore).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
> 920ff3ee33b40da45dca67f65b671b5f504b8dbf 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
> cb2e768d9483a0408d828ed23dd65f837eac8666 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> d3bf1f265c1a776d67ca5c88cb2a50211b3ec1b3 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 8331c29f505086fed6917c6f0eb5e7896adf7ea3 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
> 2b0a6a17e2306f6cf99c280d18f8469f8fe3b1a0 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  5375ed2cf45b7603d12508e7118a5bded1d87bc4 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  9041b42d89aa251d4190153b529bd35fc556f627 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ccc2f6812a539d2409d858575ee665bfd7c739d0 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  6de7e19f7758b60f937721f4ae70ef64e0f6500e 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 061d7e7d7d2ac9c7cc585b3c935cac2c572d9226 
> 
> Diff: https://reviews.apache.org/r/25831/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to