> On Sept. 20, 2014, 1:02 a.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml, > > line 275 > > <https://reviews.apache.org/r/25859/diff/1/?file=698458#file698458line275> > > > > This will fail unit tests as is.
Thanks. Fixed. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/#review54066 ----------------------------------------------------------- On Sept. 20, 2014, 12:28 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25859/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 12:28 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Angular has a thing where if you have asynchronous data *and* you bind it to > isolated scope in a directive, you need to explicitly watch the values for > changes. This was also the weird behaviour I saw before with SmartTable. > > I changed the ordering of update summaries to be reverse sorted by last event > time. Going to be required for a future (show me all in-flight updates) > feature. > > I also fixed a couple of problems with: progress stats, a missing terminal > state and the instance summary not updating when polling. > > > Diffs > ----- > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js > bcb094adbafdf223eda49c012005994937d5dcf6 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js > 8b7fc0627597d53a788868d0ae16c0c063f36338 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js > 8a719f85b0a095a93b723c04b0a5e8306093c572 > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > ad877ed168f80cc56561dffd028cff300336ea55 > > Diff: https://reviews.apache.org/r/25859/diff/ > > > Testing > ------- > > ./gradlew jsHint > > > Thanks, > > David McLaughlin > >
