-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/
-----------------------------------------------------------

(Updated Sept. 22, 2014, 11:52 a.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Maxim's feedback


Repository: aurora


Description
-------

Use Guice AssistedInject to construct StreamManager
Refactor other component in log to be Guice-constructed.

More info: https://github.com/google/guice/wiki/AssistedInject


Diffs (updated)
-----

  build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 
  src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 
87bd6579409e4f397f1efaa10192e271e022cade 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
816f4504f067daab3b86e1885390957ace9d4f7b 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
23ee32bcde0129716a4e652995640351b13d4b4f 
  src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java 
PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
899416fceae498353880012b8a93491cff461064 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
0cfa73f7d802b50e92e802956e0c67291fb26eb7 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa 

Diff: https://reviews.apache.org/r/25870/diff/


Testing
-------

./gradlew -Pq build

Also manually verified that the annotated methods are exported in vagrant (by 
using aurora_admin scheduler_snapshot devcluster and looking at /vars)


Thanks,

Kevin Sweeney

Reply via email to