----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25953/#review54328 -----------------------------------------------------------
Ship it! LGTM with a few minor changes. src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java <https://reviews.apache.org/r/25953/#comment94441> You should include a precondition check for desiredState being set or initialState being non-empty. src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java <https://reviews.apache.org/r/25953/#comment94443> !isEmpty() - Bill Farner On Sept. 23, 2014, 8:38 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25953/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 8:38 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-741 > https://issues.apache.org/jira/browse/AURORA-741 > > > Repository: aurora > > > Description > ------- > > Added safety checks around initial/desired state presence and converted to > left outer joins. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java > 361d3b8c0d59a0dad6b00c8a4b78ec8284383586 > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > 80535432c2c45eb2f3eb3bea4a797a99ea4fc2c9 > > src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java > aa7feb916f879f60d46ebaf53e47ba30d861c7fa > > Diff: https://reviews.apache.org/r/25953/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > >
