> On Sept. 24, 2014, 10:23 p.m., Joshua Cohen wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/latestUpdates.html, > > line 15 > > <https://reviews.apache.org/r/25963/diff/2/?file=704724#file704724line15> > > > > Nit: should we parameterize this to maintain the previous distinction > > between in progress vs completed?
Fixed. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25963/#review54465 ----------------------------------------------------------- On Sept. 24, 2014, 9:46 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25963/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2014, 9:46 p.m.) > > > Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner. > > > Bugs: AURORA-745 > https://issues.apache.org/jira/browse/AURORA-745 > > > Repository: aurora > > > Description > ------- > > Very simple first iteration. Shows only the latest 20 updates. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 392b4f7bc9d5352ed536ff83eafb4175e4860aa1 > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css > befd5908e51dcac2a0fc56b12651af11273d25c0 > src/main/resources/org/apache/aurora/scheduler/http/ui/index.html > 6434d1bc3b9f769f6f565d601fd98f99743efe8c > src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js > 082d920348f12b214b8ca2d20c11e7b4825453ed > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js > ded175a1e4b288b8978235c986db2549c22dcc7d > src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js > 4e67c4e0458cd67df7c1e523ee896b7d2e234a52 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js > f65cb5e69c2d1712b5f9da782ee2c7b3bc22cee8 > src/main/resources/org/apache/aurora/scheduler/http/ui/latestUpdates.html > PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/http/ui/updateList.html > PRE-CREATION > > Diff: https://reviews.apache.org/r/25963/diff/ > > > Testing > ------- > > ./gradlew jsHint > > > File Attachments > ---------------- > > updates page > > https://reviews.apache.org/media/uploaded/files/2014/09/23/33b2b9ff-3485-4bba-a8e8-2d4e6280e5ca__Screen_Shot_2014-09-23_at_4.15.06_PM.png > no data updates > > https://reviews.apache.org/media/uploaded/files/2014/09/23/5fe9c0bf-ef31-41a3-95c4-7aeb9abcb3b0__Screen_Shot_2014-09-23_at_4.45.59_PM.png > > > Thanks, > > David McLaughlin > >
