----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26015/#review54497 -----------------------------------------------------------
Ship it! Thanks for the test case! src/main/python/apache/aurora/client/cli/cron.py <https://reviews.apache.org/r/26015/#comment94681> Mainly confirming for myself- but this follows the expected behavior- if a job is the right name, but not a cron: INVALID_PARAMETER. If there are no jobs matching the name: INVALID_PARAMETER. - Joe Smith On Sept. 24, 2014, 7:03 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26015/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2014, 7:03 p.m.) > > > Review request for Aurora, Joe Smith and Mark Chu-Carroll. > > > Bugs: AURORA-753 > https://issues.apache.org/jira/browse/AURORA-753 > > > Repository: aurora > > > Description > ------- > > Skip past irrelevant jobs when running cron show command. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/cron.py > 3416c8e1932056725880f2007b60d77112759428 > src/test/python/apache/aurora/client/cli/test_cron.py > f488432cd68cc68fab8fce968e8605625ea3f56a > > Diff: https://reviews.apache.org/r/26015/diff/ > > > Testing > ------- > > Reproduced issue in a test case, now passes: > ./pants src/test/python/apache/aurora/client/cli:cron > > > Thanks, > > Bill Farner > >
