> On Sept. 25, 2014, 6:03 p.m., Kevin Sweeney wrote: > > build-support/jenkins/build.sh, lines 27-28 > > <https://reviews.apache.org/r/26044/diff/1/?file=705427#file705427line27> > > > > Why's this indirection needed, can't you just do > > > > ```bash > > ./build-support/hooks/pre-commit > > ```
Yeah, that's a good point - other commands already assume the script is run from the repo root. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/#review54564 ----------------------------------------------------------- On Sept. 25, 2014, 5:54 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26044/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 5:54 p.m.) > > > Review request for Aurora and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > Run python style checks in jenkins. > > > Diffs > ----- > > build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 > > Diff: https://reviews.apache.org/r/26044/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Bill Farner > >
