-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26093/#review54724
-----------------------------------------------------------



build-support/jenkins/build.sh
<https://reviews.apache.org/r/26093/#comment95010>

    without seeing the output, we have no idea.  rather than remove completely, 
i'd prefer to change this to something like:
    
    if ! ./build-support/hooks/pre-commit; then
      build-support/python/isort-check || true
      build-support/python/checkstyle-check || true
      exit 1
    fi
    
    (i know this leaks knowledge of the checks from pre-commit to build.sh, so 
we should probably add a build-support/python/check-all that build.sh and 
pre-commit can each call.)


- Brian Wickman


On Sept. 26, 2014, 7:33 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26093/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 7:33 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Not sure why, but this consistently fails in jenkins.  Reverting unless you 
> have any ideas how to sort it out.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 
> 
> Diff: https://reviews.apache.org/r/26093/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to