> On Sept. 26, 2014, 11:35 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java, line 
> > 724
> > <https://reviews.apache.org/r/26102/diff/1/?file=706432#file706432line724>
> >
> >     IIUC you could also trip this with an update that reduces the instance 
> > count in a job.  Can you add a test case for that?

Thanks for bringing this up! I now remember exactly why I did not want to 
address it in my previous changelist as it required changes in 
SchedulerThriftInterface to avoid setting TaskConfig if Range set is empty. 
Otherwise, the sql layer assert will fire.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54751
-----------------------------------------------------------


On Sept. 26, 2014, 9:34 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26102/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 9:34 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-756
>     https://issues.apache.org/jira/browse/AURORA-756
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Dropping assert on empty desired instances set.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 
> f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 5b00d3cf72adc154f130bb067723c3bd6960a314 
> 
> Diff: https://reviews.apache.org/r/26102/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to