> On Sept. 26, 2014, 8:19 p.m., Joshua Cohen wrote:
> > File Attachment: Instances removed are identified when shrinking job from 5 
> > instances to 1 - Screen Shot 2014-09-26 at 12.47.56 PM.png
> > <https://reviews.apache.org/r/26095/#fcomment29>
> >
> >     Should this be a different color?
> >     
> >     (in case that's not showing up properly, "this" is the box for the 
> > removed instance)

Removed instances have a different border color. So it's green (success) + 
black (the great void). Successful roll back looks the same (red border).


> On Sept. 26, 2014, 8:19 p.m., Joshua Cohen wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 
> > 328
> > <https://reviews.apache.org/r/26095/diff/1/?file=706256#file706256line328>
> >
> >     nit, since this function doesn't actually return the instance ids, but 
> > rather performs a callback on them, perhaps name it something more in line 
> > with its actual behavior? `actOnInstanceIdsFromRange` or `forEachInRange`

Fixed.


> On Sept. 26, 2014, 8:19 p.m., Joshua Cohen wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 
> > 439
> > <https://reviews.apache.org/r/26095/diff/1/?file=706256#file706256line439>
> >
> >     Why the extra parens around 
> > `(updateUtil.getAllInstanceIds(details.update))`

I have no idea. Removed.


> On Sept. 26, 2014, 8:19 p.m., Joshua Cohen wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 
> > 440
> > <https://reviews.apache.org/r/26095/diff/1/?file=706256#file706256line440>
> >
> >     As far as I can see, allInstances is only used here to get the length, 
> > can we just make this:
> >     
> >         var totalInstancesToBeUpdated = 
> > Object.keys(updateUtil.getAllInstanceIds(details.update).allIds).length

Right. Did it this way because that one-liner exceeds 100 characters.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26095/#review54716
-----------------------------------------------------------


On Sept. 26, 2014, 7:55 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26095/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 7:55 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-755
>     https://issues.apache.org/jira/browse/AURORA-755
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> See JIRA ticket.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> 92c78c28020d36b978f1a098202174015ace1316 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> 8ed95737ea69112d4ee04b687281d06a21d6abf6 
> 
> Diff: https://reviews.apache.org/r/26095/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Growing a job shows correct instance ids
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/26/246430ff-cf02-4701-9254-6f8e42f95b2a__Screen_Shot_2014-09-26_at_12.47.45_PM.png
> Instances removed are identified when shrinking job from 5 instances to 1
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/26/b01c5d23-080e-4433-804b-c868215c0bcb__Screen_Shot_2014-09-26_at_12.47.56_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Reply via email to