> On Sept. 28, 2014, 4:05 a.m., Joshua Cohen wrote: > > build.gradle, line 564 > > <https://reviews.apache.org/r/26123/diff/1/?file=707768#file707768line564> > > > > extra slash?
Fixed. > On Sept. 28, 2014, 4:05 a.m., Joshua Cohen wrote: > > build.gradle, lines 565-566 > > <https://reviews.apache.org/r/26123/diff/1/?file=707768#file707768line565> > > > > can we pull these values out to constants so it's easy[1] to bump them > > up as coverage increases? > > > > [1] not that it's hard, but I imagine future diffs are easier if it's > > just: > > > > + MINIMUM_LINE_COVERAGE=0.87 > > - MINIMUM_LINE_COVERAGE=0.86 Done. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54772 ----------------------------------------------------------- On Sept. 27, 2014, 11:25 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26123/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2014, 11:25 p.m.) > > > Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > This will fail the build if: > - global line or branch coverage is below a threshold > - a class has no test coverage > - a class flagged as known to have no coverage gains coverage > > Hopefully we can all contribute to whittle the legacy non-covered list down > to zero. > > > Diffs > ----- > > build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 > > Diff: https://reviews.apache.org/r/26123/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > > Thanks, > > Bill Farner > >
