-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26154/#review54898
-----------------------------------------------------------

Ship it!



src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java
<https://reviews.apache.org/r/26154/#comment95229>

    Prefer 
http://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html
    
    From https://code.google.com/p/guava-libraries/wiki/StringsExplained
    
    (Note: If you're using JDK7, you should use the constants in 
StandardCharsets instead!)


- Kevin Sweeney


On Sept. 29, 2014, 3:12 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26154/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 3:12 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> 
> 
> Bugs: AURORA-764
>     https://issues.apache.org/jira/browse/AURORA-764
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Stop sending and receiving DeletedTasks framework message.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
> e4439f6a28535f774cfdc1000a0d6d2976254aee 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 6701caa34ca70225d2d286c1b2912933eb3ba405 
>   src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
> 842b011049018724b114898ace3d870f51ccfab4 
>   src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 
> 606b5b03616c8ddbc83cb89f1206feb409f187c2 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> e9bc7eb3b586c49e718804cbd630a871318caef8 
> 
> Diff: https://reviews.apache.org/r/26154/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to