-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/#review54916
-----------------------------------------------------------



src/main/python/apache/aurora/executor/common/announcer.py
<https://reviews.apache.org/r/25974/#comment95251>

    this data is available within the mesos_task struct created in 
from_assigned_task.  you should be getting the information from there as it may 
contain default values not required to be populated in the executorConfig json 
(in which case you'd be getting KeyErrors from make_serverset.)



src/main/python/apache/aurora/executor/common/announcer.py
<https://reviews.apache.org/r/25974/#comment95257>

    i feel like we should be calling start_async instead, though this 
complicates implementation slightly.
    
    we want the creation of all the status managers to be non-blocking since 
the executor will be in a transient (TASK_STARTING) state, which can possibly 
timeout and go to TASK_LOST, which is less preferable than TASK_FAILED.
    
    client.create_async returns a threading.Event.  we'd want (in a separate 
thread) to event.wait(timeout=timeout) and if not event.is_set(), set the 
.healthy property on the Announcer to StatusResult(..., mesos_pb2.TASK_FAILED)
    
    alternately, you could ignore the threading.Event from create_async and 
bake that logic into the contract between Announcer<->ServerSetJoinThread.  i'm 
not sure which is simpler or cleaner.


- Brian Wickman


On Sept. 29, 2014, 9:46 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25974/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 9:46 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-728
>     https://issues.apache.org/jira/browse/AURORA-728
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Prevent initial ZK timeouts from killing the executor. In addition, prevent 
> uncaught exceptions from killing the executor.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 79a24855b2a68271b7478395dfdadab8755c3af2 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> c466da8d48bbc2aa227c2db157cab84665ad6602 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 
> 
> Diff: https://reviews.apache.org/r/25974/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/executor:executor-small
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to