> On Sept. 30, 2014, 1:38 a.m., Maxim Khutornenko wrote:
> > Not quite obvious from the diff: why was not it enough to check the noop 
> > condition in the controller only?

`SchedulerThriftInterface` would get a `JobDiff`, and use that to build 
`IJobUpdateInstructions`.  `JobUpdateControllerImpl` would take that, and 
calculate a diff against the state of the job.  i.e. we were performing a diff 
against a diff, which gets weird when the instance count changes.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26158/#review54934
-----------------------------------------------------------


On Sept. 30, 2014, 12:59 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26158/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 12:59 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-769
>     https://issues.apache.org/jira/browse/AURORA-769
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Perform job update no-op detection in SchedulerThriftInterface.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  2847bdbb773f4d5a7f31b52ceb806880e736a259 
>   src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 
> 9d02474751ed22cb2dfd7903aa715d53b5ac805e 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> f37fbef4c50cfc2d98bc1fd89376a210f4fa8643 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  97bc1dfbbd83d30d6e94b70902f225f2c92acb77 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  12b19fd333a95d0d3d1864bac629d011c271ee52 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 7254588b55df9a12217c8ec172abc5976892497e 
> 
> Diff: https://reviews.apache.org/r/26158/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> Ran a no-op update in vagrant and saw expected behavior.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to