> On Oct. 1, 2014, 10:41 a.m., Kevin Sweeney wrote:
> > docs/monitoring.md, line 184
> > <https://reviews.apache.org/r/26233/diff/2/?file=710149#file710149line184>
> >
> >     style point: we've rendered command-line flags with a single dash in 
> > other documentation. Though both are acceptable it would be good to 
> > internally standardize on one style.
> 
> Bill Farner wrote:
>     Thanks, this isn't even a style point as much as a bad doc.  The command 
> line parser requires a single dash here.  Fixed.

aha, tmyk


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/#review55089
-----------------------------------------------------------


On Oct. 1, 2014, 10:56 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26233/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 10:56 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-634
>     https://issues.apache.org/jira/browse/AURORA-634
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a monitoring guide.
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176 
>   docs/monitoring.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26233/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: 
> https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
> 
> I'm not terribly happy about the organization at the bottom, specifically the 
> wrapping of rate ratio. Happy to rework if anybody has a suggestion.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to