-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/#review55158
-----------------------------------------------------------



src/main/python/apache/aurora/executor/common/announcer.py
<https://reviews.apache.org/r/25974/#comment95541>

    i think "if self.__connect_event.is_set()" is more accurate -- it's 
possible for it to be connected and then race with disconnection.  we just want 
to validate that it managed to connect initially.
    
    this complicates your test a little bit since you do connected.set() right 
off the bat.  but you might be able to get around this by making a 
HealthCheckConfig that produces a tiny timeout.



src/test/python/apache/aurora/executor/common/test_announcer.py
<https://reviews.apache.org/r/25974/#comment95542>

    out of scope for this review, but there's a new-ish pypi project called 
'zake' that allows the kazoo client to be stubbed out with a mock zk tree 
(while preserving certain operations like create/delete.)  i'd love to explore 
using it here in the future.


- Brian Wickman


On Oct. 1, 2014, 12:17 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25974/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 12:17 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-728
>     https://issues.apache.org/jira/browse/AURORA-728
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Prevent initial ZK timeouts from killing the executor. In addition, prevent 
> uncaught exceptions from killing the executor.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 79a24855b2a68271b7478395dfdadab8755c3af2 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> c466da8d48bbc2aa227c2db157cab84665ad6602 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 
> 
> Diff: https://reviews.apache.org/r/25974/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/executor:executor-small
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to