----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55371 -----------------------------------------------------------
Looks great- thanks! src/test/python/apache/thermos/core/test_helper.py <https://reviews.apache.org/r/25972/#comment95731> from psutil._common import puids - Joe Smith On Oct. 3, 2014, 10:55 a.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25972/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 10:55 a.m.) > > > Review request for Aurora, Joe Smith and Kevin Sweeney. > > > Bugs: AURORA-175 > https://issues.apache.org/jira/browse/AURORA-175 > > > Repository: aurora > > > Description > ------- > > This is changes 1 of 2 for AURORA-175. The second change adds an exit status > contract between Aurora and Thermos. > > This change allows a process in the Thermos state machine to go directly from > WAITING -> FAILED if the user associated with that process has been deleted. > It also persists a 'uid' field to the Thermos RunnerHeader so that we can > check against process UIDs which in theory have higher fidelity than > usernames. > > > Diffs > ----- > > src/main/python/apache/thermos/common/ckpt.py > 7df179b135e896d52655667f0707850a4bc33068 > src/main/python/apache/thermos/core/helper.py > 82c68f3af424d3309db3816080465edd1ff1a87c > src/main/python/apache/thermos/core/process.py > 4889e636c2fa7325852684cecd87a2123714144d > src/main/python/apache/thermos/core/runner.py > 31f40713ec32c0626566899caec76f2a9985c7bf > src/main/thrift/org/apache/thermos/thermos_internal.thrift > 0cea1057230b367c9d55b773854453cee2f9fce0 > src/test/python/apache/thermos/core/test_helper.py > 53f1e467283b45598b3f1865951c42b13579a512 > src/test/python/apache/thermos/core/test_process.py > 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1 > > Diff: https://reviews.apache.org/r/25972/diff/ > > > Testing > ------- > > > Thanks, > > Brian Wickman > >
