----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55404 -----------------------------------------------------------
Kevin, Mark - ping? - Bill Farner On Oct. 3, 2014, 4:52 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26308/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 4:52 a.m.) > > > Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. > > > Repository: aurora > > > Description > ------- > > Fixes two problems: > > - mocking was incorrect in `test_status_api_failure`. Turns out that Mock > objects were being passed around and somehow resulted in the test case > passing. > - use of `threading.Event()` was broken in scheduler_client.py. I don't > think it's possible to enter those branches. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/scheduler_client.py > b400cb2dbdb35077fc2c4a6e161c2959a9217317 > src/test/python/apache/aurora/client/api/test_scheduler_client.py > 1cbfbf86e903d890baac7d34461109f9beaff442 > src/test/python/apache/aurora/client/cli/test_api_from_cli.py > 78f21d2f20cf71fa2dfe0614885d44d2948decd2 > > Diff: https://reviews.apache.org/r/26308/diff/ > > > Testing > ------- > > ./pants src/test/python:all -vxs > > > Thanks, > > Bill Farner > >
