-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/
-----------------------------------------------------------

(Updated Oct. 3, 2014, 11:25 p.m.)


Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.


Changes
-------

I need to do some more work here - started pulling a thread on using 
`TaskQuery.jobKeys`.  Still need to correct some tests after that switch.


Repository: aurora


Description
-------

Fixes two problems:

- mocking was incorrect in `test_status_api_failure`.  Turns out that Mock 
objects were being passed around and somehow resulted in the test case passing.
- use of `threading.Event()` was broken in scheduler_client.py.  I don't think 
it's possible to enter those branches.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/api/__init__.py 
e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba 
  src/main/python/apache/aurora/client/api/command_runner.py 
a1fed5fc75dde3a79c840515e6daa4741156ef97 
  src/main/python/apache/aurora/client/api/job_monitor.py 
756093dff8cf101158f2be803cc31f43ceabe654 
  src/main/python/apache/aurora/client/api/scheduler_client.py 
b400cb2dbdb35077fc2c4a6e161c2959a9217317 
  src/main/python/apache/aurora/client/api/updater.py 
bf608981c2f2e7960b68c3fbda144277a59a3d40 
  src/main/python/apache/aurora/common/aurora_job_key.py 
a7ca7b6df6b9566b3ce617283ccac948deb2eb83 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
1cbfbf86e903d890baac7d34461109f9beaff442 
  src/test/python/apache/aurora/client/api/test_updater.py 
e4c9ad026323fc51ff8b9a2960abf9efdee6c898 
  src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
78f21d2f20cf71fa2dfe0614885d44d2948decd2 
  src/test/python/apache/aurora/client/cli/test_create.py 
6e55188bdfc576506848605debb391288e696fe3 
  src/test/python/apache/aurora/client/cli/test_kill.py 
e3a366bf67074e50787394cad58d5e01359b641e 
  src/test/python/apache/aurora/client/cli/test_status.py 
bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 
  src/test/python/apache/aurora/client/cli/test_task_run.py 
1ce9a632874e818eee71573cd481842affae3615 
  src/test/python/apache/aurora/client/commands/test_kill.py 
3e6d048590b07603540b3dab026c8fde3c3c4ba4 

Diff: https://reviews.apache.org/r/26308/diff/


Testing
-------

./pants src/test/python:all -vxs


Thanks,

Bill Farner

Reply via email to