-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26363/#review55512
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/26363/#comment95894>

    Are these debug statements? Should they be removed or switched to log.debug?



src/test/python/apache/aurora/client/cli/test_update.py
<https://reviews.apache.org/r/26363/#comment95895>

    This sequence of mocks and writing config to a file is repeated in... many 
(all?) of these tests. Can you refactor to remove the repetition?


- Joshua Cohen


On Oct. 6, 2014, 2:57 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26363/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 2:57 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-792
>     https://issues.apache.org/jira/browse/aurora-792
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make the large-update check in the client update command consider instance 
> parameters.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> 301531fcb443297facb78d87a18073c8b7fd4064 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 103fb53cb5101d3e025d8712e3887bccdfbb6aeb 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 8ce6bd5b7faa1579372fb6935180ea982af64af8 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 85b1db19d89967a741bfba7964eeb368426f0b61 
> 
> Diff: https://reviews.apache.org/r/26363/diff/
> 
> 
> Testing
> -------
> 
> New unit tests added, all test pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to