-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/
-----------------------------------------------------------
(Updated Oct. 6, 2014, 9:58 a.m.)
Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Zameer Manji.
Changes
-------
Fix summary
Summary (updated)
-----------------
Test all the nouns and verbs within the Aurora Command Line for help output
Bugs: AURORA-748
https://issues.apache.org/jira/browse/AURORA-748
Repository: aurora
Description (updated)
-------
This steps through each noun within the commandline, and each verb attached to
those nouns to validate help output appears as expected.
Diffs
-----
src/main/python/apache/aurora/client/cli/update.py
b4dd792dc12f19424c620f4d91748113e272f0c9
src/test/python/apache/aurora/client/cli/test_help.py
e1602b145a6b100efca8663104a7d44cc119c5a5
Diff: https://reviews.apache.org/r/26372/diff/
Testing
-------
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
====================================================================================================================================================
test session starts
=====================================================================================================================================================
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py ......
==================================================================================================================================================
6 passed in 0.71 seconds
==================================================================================================================================================
src.test.python.apache.aurora.client.cli.help
..... SUCCESS
And confirmed via:
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff
diff --git a/src/main/python/apache/aurora/client/cli/update.py
b/src/main/python/apache/aurora/client/cli/update.py
index 41475a7..142ba5e 100644
--- a/src/main/python/apache/aurora/client/cli/update.py
+++ b/src/main/python/apache/aurora/client/cli/update.py
@@ -42,7 +42,7 @@ class StartUpdate(Verb):
INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT
]
- @property
+ #@property
def help(self):
return textwrap.dedent("""\
Start a scheduler-driven rolling upgrade on a running job, using the
update
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
====================================================================================================================================================
test session starts
=====================================================================================================================================================
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py F.....
==========================================================================================================================================================
FAILURES
==========================================================================================================================================================
___________________________________________________________________________________________________________________________________________________
TestHelp.test_all_help
___________________________________________________________________________________________________________________________________________________
self = <test_help.TestHelp testMethod=test_all_help>
def test_all_help(self):
for noun in self.cmd.registered_nouns:
with
patch('apache.aurora.client.cli.client.AuroraCommandLine.print_out',
side_effect=self.mock_print):
self.cmd.execute(['help', noun])
assert 'Usage for noun "%s":' % noun in self.transcript
assert self.err_transcript == []
self.transcript = []
for verb in self.cmd.nouns.get(noun).verbs.keys():
self.cmd.execute(['help', noun, verb])
> assert 'Usage for verb "%s %s":' % (noun, verb) in self.transcript
E AssertionError: assert ('Usage for verb "%s %s":' % ('beta-update',
'start')) in []
E + where [] = <test_help.TestHelp
testMethod=test_all_help>.transcript
src/test/python/apache/aurora/client/cli/test_help.py:50: AssertionError
----------------------------------------------------------------------------------------------------------------------------------------------------
Captured stderr call
----------------------------------------------------------------------------------------------------------------------------------------------------
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod
found
=============================================================================================================================================
1 failed, 5 passed in 0.88 seconds
=============================================================================================================================================
src.test.python.apache.aurora.client.cli.help
..... FAILURE
Thanks,
Joe Smith
