----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/#review55522 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/context.py <https://reviews.apache.org/r/26288/#comment95901> When I wrote code that did that check, Bill specifically told me to remove it, because anything in the deprecated field would *always* also be in the details list. So unless we're moving backwards, this is the wrong approach. If there's a place where the scheduler is sending things via the deprecated field but not via the details list, then that should be changed. - Mark Chu-Carroll On Oct. 2, 2014, 6:28 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26288/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 6:28 p.m.) > > > Review request for Aurora and Mark Chu-Carroll. > > > Bugs: AURORA-786 > https://issues.apache.org/jira/browse/AURORA-786 > > > Repository: aurora > > > Description > ------- > > Fixing log_response in context.py > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/context.py > f639af7de93a069b278dc494b6f92a2f6b10de9c > src/test/python/apache/aurora/client/cli/BUILD > 8ce6bd5b7faa1579372fb6935180ea982af64af8 > src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION > > Diff: https://reviews.apache.org/r/26288/diff/ > > > Testing > ------- > > ./pants src/tests/python:all > > > Thanks, > > Maxim Khutornenko > >
