----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55698 -----------------------------------------------------------
Ship it! src/test/python/apache/aurora/common/test_transport.py <https://reviews.apache.org/r/26424/#comment96076> I think this can be removed- we're validating what we want here. Although I'm not quite a fan of this global state being modified via module import, I'm not sure we need to have an entirely separate test file that gets executed just to check the before/after. - Joe Smith On Oct. 7, 2014, 12:58 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26424/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2014, 12:58 p.m.) > > > Review request for Aurora, Joe Smith and Bill Farner. > > > Bugs: AURORA-770 > https://issues.apache.org/jira/browse/AURORA-770 > > > Repository: aurora > > > Description > ------- > > Disable requests http connection logging. > > > Diffs > ----- > > src/main/python/apache/aurora/common/transport.py > 6f7c355d725b5e537cc4ae471170eaa8431da326 > src/test/python/apache/aurora/common/test_transport.py > c722eae2d04dec90e9c772f49c578184a2bdf76c > > Diff: https://reviews.apache.org/r/26424/diff/ > > > Testing > ------- > > Added hokey test, ran hokey test. > > Also verified the lack of http connection logs when running client commands > directly. > > > Thanks, > > Joshua Cohen > >