> On Oct. 8, 2014, 1:58 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 435 > > <https://reviews.apache.org/r/26328/diff/2/?file=714194#file714194line435> > > > > It writes into the current directory where the user is executing the > > client.
This is going to lead to complaints. On the dev list, John wrote: "The full backtrace goes off to a file in the user's home dir somewhere and then you can ask them to run a command passing the pill ref to get the full error report without worry of re-running some non-idempotent command, etc." So I really think we should write them to a consistent and predictable location. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review55794 ----------------------------------------------------------- On Oct. 8, 2014, 2:42 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26328/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 2:42 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: aurora-779 > https://issues.apache.org/jira/browse/aurora-779 > > > Repository: aurora > > > Description > ------- > > Improve handling of unknown errors in the aurora client. > > Instead of dumping the stack on the user's terminal, or > absorbing the error and generating a brief error > message, the client now writes detailed information about > the error is written into an error log file, and the > user is given a clean error message referring them to that > file for details. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > e0c3050151bca1128ed7e476ec5133407a20f6c2 > src/main/python/apache/aurora/client/cli/standalone_client.py > 7c0975ce9d415b19b6704b9a772ee2619ac9a2af > src/test/python/apache/aurora/client/cli/test_api_from_cli.py > 78f21d2f20cf71fa2dfe0614885d44d2948decd2 > src/test/python/apache/aurora/client/cli/test_create.py > 6e55188bdfc576506848605debb391288e696fe3 > > Diff: https://reviews.apache.org/r/26328/diff/ > > > Testing > ------- > > New unit test. > > > Thanks, > > Mark Chu-Carroll > >