----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26422/#review55854 -----------------------------------------------------------
Ship it! Thanks for the extra look! - Bill Farner On Oct. 8, 2014, 5:27 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26422/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 5:27 p.m.) > > > Review request for Aurora, David McLaughlin, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-801 > https://issues.apache.org/jira/browse/AURORA-801 > > > Repository: aurora > > > Description > ------- > > Drop syncrhonized from JobUpdateEventSubscriber > > This fixes a startup deadlock. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java > 49d8b7a6c4adc4c58049c439bd09019c9e6885b1 > > Diff: https://reviews.apache.org/r/26422/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > Manually verified that all delegated calls to the JobUpdateController are > already protected by the storage write-lock. > > Rather than add a potentially-flaky regression test (like the one added in > https://reviews.apache.org/r/25556/) I'd prefer to prioritize adding runtime > deadlock detection (https://issues.apache.org/jira/browse/AURORA-800). > > > Thanks, > > Kevin Sweeney > >
