----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/#review55870 -----------------------------------------------------------
src/main/python/apache/aurora/client/config.py <https://reviews.apache.org/r/26430/#comment96239> default environments are also deprecated and should be removed. src/main/python/apache/aurora/config/thrift.py <https://reviews.apache.org/r/26430/#comment96241> cron_policy shouldn't be empty right? since it's a Default() field. src/main/python/apache/aurora/config/thrift.py <https://reviews.apache.org/r/26430/#comment96242> same -- service is a Default(Boolean, False) so has_service() should never be false. - Brian Wickman On Oct. 8, 2014, 12:05 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26430/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 12:05 a.m.) > > > Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. > > > Bugs: AURORA-333 > https://issues.apache.org/jira/browse/AURORA-333 > > > Repository: aurora > > > Description > ------- > > This removes several long deprecated configuration options from aurora. > > The features removed are cron_policy, daemon, health_check_interval_secs, > recipes and the PackerObject > > > Diffs > ----- > > docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec > src/main/python/apache/aurora/client/binding_helper.py > 6d6a06785c6840e4345e304eb4e242682676ac66 > src/main/python/apache/aurora/client/config.py > e440f587d100ce46b2df85ccc663912c615051ef > src/main/python/apache/aurora/config/recipes.py > 68b5d252f87a592d4c2f7d52525163829bea2cc9 > src/main/python/apache/aurora/config/schema/base.py > f12634f103c3eb20e43f37c25d9b0fc3e3d228ec > src/main/python/apache/aurora/config/thrift.py > 288fb40f65629c8fd4eb7d92c8bf02369237de3b > src/test/python/apache/aurora/client/cli/test_status.py > 38ffdb86c5f577ebf3a482128588331a63af15d1 > src/test/python/apache/aurora/client/cli/util.py > ff7eda20dbba073c8b24fbe3f4389292aab2d128 > src/test/python/apache/aurora/client/commands/util.py > 663f2f4a16113a36826943b7238cad900ae0dcd2 > src/test/python/apache/aurora/config/test_thrift.py > fd28313df2cfd5a9c7d00f6d329518b4caabacb2 > > Diff: https://reviews.apache.org/r/26430/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Zameer Manji > >