----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/#review55899 -----------------------------------------------------------
src/main/python/apache/aurora/admin/host_maintenance.py <https://reviews.apache.org/r/26458/#comment96275> Is this provided so external modules can interact with the maintenance? src/main/python/apache/aurora/admin/host_maintenance.py <https://reviews.apache.org/r/26458/#comment96274> move out to its own method? src/main/python/apache/aurora/admin/host_maintenance.py <https://reviews.apache.org/r/26458/#comment96277> Maybe just raise a normal exception instead? :) (and maybe log which hosts weren't moved?) src/test/python/apache/aurora/admin/test_host_maintenance.py <https://reviews.apache.org/r/26458/#comment96279> can you assert on how many times this was called? - Joe Smith On Oct. 8, 2014, 2:40 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26458/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 2:40 p.m.) > > > Review request for Aurora, Joe Smith and Brian Wickman. > > > Bugs: AURORA-820 > https://issues.apache.org/jira/browse/AURORA-820 > > > Repository: aurora > > > Description > ------- > > Throttling status check calls now at a predefined 5 second interval with a > max timeout of 5 minutes. > > > Diffs > ----- > > src/main/python/apache/aurora/admin/host_maintenance.py > 9c2a9f77109791da574e1624d27b6b7096a2678e > src/test/python/apache/aurora/admin/test_host_maintenance.py > 40228df59e43bc6034f2dc651c166a0c4b78aea8 > > Diff: https://reviews.apache.org/r/26458/diff/ > > > Testing > ------- > > ./pants src/test/python:all > > > Thanks, > > Maxim Khutornenko > >