> On Oct. 8, 2014, 11:50 p.m., Joshua Cohen wrote:
> > This doesn't actually fail when I run it locally. I'm worried that we're 
> > just fixing a symptom of the problem, and not the problem itself (i.e. 
> > we're going to be adding random classes to the legacy list despite their 
> > actually having coverage).
> 
> Bill Farner wrote:
>     I suspect you might be right.  I want to get to the bottom of this, since 
> i think the no-coverage check is really useful.  The next time we notice one 
> of these, let's remember to capture 
> `dist/reports/jacoco/test/jacocoTestReport.xml`.  That's what the check uses, 
> and it will help us determine if the check is faulty, or jacoco is doing 
> something odd.
> 
> Joshua Cohen wrote:
>     In this case I think it is uncovering an actual case where coverage was 
> lost (because the static asset changes serve the html directly without going 
> through ApiBeta, I'll have a review out shortly to kill that code). That 
> being said, this check never failed for me locally which was super strange. I 
> had to run the tests locally in a debugger and confirm the breakpoint was not 
> hit.

https://reviews.apache.org/r/26469/


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26464/#review55900
-----------------------------------------------------------


On Oct. 8, 2014, 11:09 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26464/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 11:09 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-819
>     https://issues.apache.org/jira/browse/AURORA-819
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The org/apache/aurora/scheduler/http/api/ApiBeta$2 class has no coverage so 
> we blacklist it.
> 
> 
> Diffs
> -----
> 
>   build.gradle 2e1bf78d7797f17afd51a94a22eff80e00aba464 
> 
> Diff: https://reviews.apache.org/r/26464/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to