> On Oct. 8, 2014, 6:09 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, line 41
> > <https://reviews.apache.org/r/26383/diff/2/?file=716291#file716291line41>
> >
> >     Why add a default value here?
> 
> David Pan wrote:
>     The reason why ThreadedHealthChecker has defaults is because some tests 
> for ThreadedHealthChecker don't care about all the parameters to 
> ThreadedHealthChecker.  For example, if my test doesn't care about the 
> interval_secs, the defaults allow me to ignore that parameter altogether, and 
> focus on the parameters that I actually care about.

It isn't acceptable to alter parameters like that. Please modify your tests to 
pass in a value instead.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review55924
-----------------------------------------------------------


On Oct. 8, 2014, 5:46 p.m., David Pan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26383/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 5:46 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The health check disabler allows health checks for a job to be snoozed 
> temporarily by touching a snooze file in the job's sandbox.  The appropriate 
> unit tests were modified/added.
> 
> The corresponding JIRA ticket is the following:
> https://issues.apache.org/jira/browse/AURORA-795
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 4980411c847d12655cbb363404707ebd9f0bd163 
>   src/test/python/apache/aurora/executor/common/BUILD 
> c7f7a003c865d479ba6e3cd7b5349322f884f653 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> aa36415fa891fc523a3a376ffeca5d3cd5ceabec 
> 
> Diff: https://reviews.apache.org/r/26383/diff/
> 
> 
> Testing
> -------
> 
> On vagrant in ~/aurora, I ran
> ./pants src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> David Pan
> 
>

Reply via email to