I can also verify that running the entire test suite in a debugger, a breakpoint set in OfferQueue$OfferQueueImpl$2 is not hit.
On Thu, Oct 9, 2014 at 10:05 AM, Joshua Cohen <jco...@twopensource.com> wrote: > Nope, it's passing for me, but it's similar to the behavior I was seeing > with ApiBeta$2; even after cleaning the reports directory I was *not* > getting the failure about it missing coverage even though it actually was. > > On Thu, Oct 9, 2014 at 8:32 AM, Bill Farner <wfar...@apache.org> wrote: > >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/26469/ >> >> On October 9th, 2014, 2:32 p.m. UTC, *Bill Farner* wrote: >> >> Ship It! >> >> Hmm, i'm now getting a different coverage error when preparing to submit >> this: >> >> * What went wrong: >> Execution failed for task ':jacocoTestReport'.> Thanks for adding the first >> test coverage to: >> org/apache/aurora/scheduler/async/OfferQueue$OfferQueueImpl$2 please remove >> it from the legacyClassesWithoutCoverage list. Expression: (coverage == 0). >> Values: coverage = 6 >> >> This remains after cleaning the reports directory. Do you see that one >> as well? >> >> >> - Bill >> >> On October 9th, 2014, 12:15 a.m. UTC, Joshua Cohen wrote: >> Review request for Aurora, Bill Farner and Zameer Manji. >> By Joshua Cohen. >> >> *Updated Oct. 9, 2014, 12:15 a.m.* >> *Repository: * aurora >> Description >> >> Kill code to serve ApiBeta help pages that's no longer used now that the >> content is served directly. >> >> Testing >> >> ./gradlew build -Pq >> >> $ curl -I http://192.168.33.7:8081/apibeta/help/method/setQuota.html >> >> HTTP/1.1 200 OK >> >> Content-Type: text/html >> >> Vary: Accept-Encoding >> >> Content-Length: 0 >> >> Server: Jetty(7.6.15.v20140411) >> >> Diffs >> >> - build.gradle (8f7eed0b58a00f8e5e0521512975087d5788b5b6) >> - src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java >> (eaf63382f689a045f837847736ef24fa75dee874) >> - src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java >> (62154045f49c5b23949dc739d735c3e5d3680b89) >> >> View Diff <https://reviews.apache.org/r/26469/diff/> >> > >