----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review56206 -----------------------------------------------------------
src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/26531/#comment96529> This doesn't match the doc you sent out? Shouldn't this just be one of [OK, STOP, ERRROR]? (JobUpdateStatus has a much wider set of values of which only ERROR is included) - Joshua Cohen On Oct. 9, 2014, 11:23 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26531/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 11:23 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. > > > Bugs: AURORA-690 > https://issues.apache.org/jira/browse/AURORA-690 > > > Repository: aurora > > > Description > ------- > > Defining the flag and the schema for the update coordination (aka heartbeats). > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > 77032d84f91b149c01ce4ac62da7ca331a2b6445 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > db6a8719d18fee720f74ebcd2079ad36201cc831 > src/main/thrift/org/apache/aurora/gen/api.thrift > 8794731f4b3f1033588bdfa33c292e4796319a2a > > src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java > 3871dae68fcdc6402cb61a7244b46114617eecff > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e > src/test/python/apache/aurora/client/api/test_scheduler_client.py > d78e7dca28d67997bc6c98cff619ab94a257c7dc > > Diff: https://reviews.apache.org/r/26531/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
