-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26574/#review56228
-----------------------------------------------------------

Ship it!


I'm fine shipping this, we can have a separate discussion about organizing 
build.gradle.

- Joshua Cohen


On Oct. 10, 2014, 9:41 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26574/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 9:41 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-822
>     https://issues.apache.org/jira/browse/AURORA-822
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> `javac` inserts synthetic zero-arg constructors into anonymous classes, which 
> jacoco sometimes detects as covered by tests.  This was throwing off the 
> "each class must have _some_ coverage" by considering classes without 
> coverage to actually have some coverage.
> 
> I've attempted to fix this by ignoring the default constructor in anonymoous 
> classes, which should be more accurate.  One sign that this is working — lots 
> of modules came onto the radar as lacking coverage, which is legitimate.
> 
> 
> Diffs
> -----
> 
>   build.gradle 8f7eed0b58a00f8e5e0521512975087d5788b5b6 
> 
> Diff: https://reviews.apache.org/r/26574/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> I also verified that i can now cherry-pick the patch from 
> https://reviews.apache.org/r/26469/ and produce a green build.  On master, i 
> consistently get a coverage error.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to