> On Oct. 13, 2014, 11:08 p.m., Kevin Sweeney wrote:
> > buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy, line 
> > 18
> > <https://reviews.apache.org/r/26662/diff/2/?file=719791#file719791line18>
> >
> >     typo in analyzes

Fixed.


> On Oct. 13, 2014, 11:08 p.m., Kevin Sweeney wrote:
> > buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy, line 
> > 61
> > <https://reviews.apache.org/r/26662/diff/2/?file=719791#file719791line61>
> >
> >     typo in "anonymous"

Fixed.


> On Oct. 13, 2014, 11:08 p.m., Kevin Sweeney wrote:
> > buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy, line 
> > 53
> > <https://reviews.apache.org/r/26662/diff/2/?file=719791#file719791line53>
> >
> >     I think you want to throw a GradleException here and below

Went with `TaskExecutionException`, LMK if you disagree.

> A TaskExecutionException is thrown when a task fails to execute successfully.

http://www.gradle.org/docs/current/javadoc/org/gradle/api/tasks/TaskExecutionException.html


> On Oct. 13, 2014, 11:08 p.m., Kevin Sweeney wrote:
> > build.gradle, line 642
> > <https://reviews.apache.org/r/26662/diff/2/?file=719790#file719790line642>
> >
> >     Does this slow down the build at all (you're now doing I/O in 
> > configure?)

My unscientific efforts say: not in any way i can measure.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26662/#review56459
-----------------------------------------------------------


On Oct. 13, 2014, 11:03 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26662/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 11:03 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-833
>     https://issues.apache.org/jira/browse/AURORA-833
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Making good on a TODO from https://reviews.apache.org/r/26574/
> 
> 
> Diffs
> -----
> 
>   .gitignore ad4206d179b46f1269fd58c62de9e6e62f4b8738 
>   build.gradle c200746ff9ce2d7ff973c22764d9413bf64636e7 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 
> PRE-CREATION 
>   config/legacy_untested_classes.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26662/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to