----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26662/#review56466 -----------------------------------------------------------
Ship it! Looks good to me modulo Kevin's comments. buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy <https://reviews.apache.org/r/26662/#comment96820> I'm not super familiar w/ groovy, any reason why we can't just inline the computeCoverage(...) call here (and below)? - Joshua Cohen On Oct. 13, 2014, 11:03 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26662/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2014, 11:03 p.m.) > > > Review request for Aurora, Joshua Cohen and Kevin Sweeney. > > > Bugs: AURORA-833 > https://issues.apache.org/jira/browse/AURORA-833 > > > Repository: aurora > > > Description > ------- > > Making good on a TODO from https://reviews.apache.org/r/26574/ > > > Diffs > ----- > > .gitignore ad4206d179b46f1269fd58c62de9e6e62f4b8738 > build.gradle c200746ff9ce2d7ff973c22764d9413bf64636e7 > buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy > PRE-CREATION > config/legacy_untested_classes.txt PRE-CREATION > > Diff: https://reviews.apache.org/r/26662/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > > Thanks, > > Bill Farner > >
