> On Oct. 14, 2014, 11:26 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java, 
> > line 183
> > <https://reviews.apache.org/r/26664/diff/1/?file=719801#file719801line183>
> >
> >     Isn't this unsafe?  Seems like we need to treat the state the same in 
> > 0.6.0, and then actually change behavior and remove in 0.7.0.
> 
> Bill Farner wrote:
>     Sorry for the delayed/brief review - stopped short at the compatibility 
> issue.  We could move forward with some behavioral changes within the 
> scheduler, so long as we rewrite `SANDBOX_DELETED` into something else 
> (probably just deleting that `TaskEvent` and re-surfacing the previous).
> 
> Maxim Khutornenko wrote:
>     Yeah, that's exactly what is happening in StorageBackfill.java.

:sigh: i swore i scanned and even did a ctrl-f for good measure :-/
Returning for another look.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26664/#review56599
-----------------------------------------------------------


On Oct. 13, 2014, 11:22 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26664/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 11:22 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-751
>     https://issues.apache.org/jira/browse/AURORA-751
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Dropping the SANDBOX_DELETED from the scheduler.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> cfab57896f9c76754ba3b42742504fb7e7a2cf79 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java 
> 9ba83fa93409de7c6254bd8e7cc27e6bc10186e0 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 0f6731106c53420b92e60b9faf26c3614bd7ae00 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 86a8eb57ce7074f71d5212b34defe4320a5c430d 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> 8c20ab6f2bebf1d1c0f91fed3f1e48361cdf45d6 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 9b40adaaa3634a451b4047915485e0e97d8f7914 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 7e9037ee921b009dc2b7c5adcf057bedebb01632 
>   src/main/resources/scheduler/assets/js/filters.js 
> 7e8ca8408628d6f658da4267eb763e8fb4cb68c9 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8794731f4b3f1033588bdfa33c292e4796319a2a 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 606c4434b7158220ccf1403b6deac939021fee31 
>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
> f2d153f446247032ad9d8d173fb70870dbfdcca1 
>   src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java 
> 53d2c6bb78ad08a84639c1ecd48ba64d17c3f9fc 
>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java 
> f3b6ff0aa72c873d6b3cf3a1d327033c791ff6b9 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> eccf0c757d1e6addcd7619120f96ffa5f1ac38b5 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> cdd29ea2b6fc92b967571028d299260556e16d42 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> cb3254728a697a963b92baff31b02dafa2be0039 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 80646a685ea918d80efafc5773e5805000a9c012 
> 
> Diff: https://reviews.apache.org/r/26664/diff/
> 
> 
> Testing
> -------
> 
> ./gradle -Pq build
> Verified UI in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to