-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26688/#review56737
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/standalone_client.py
<https://reviews.apache.org/r/26688/#comment97119>

    It's the standard python loglevels. The number is basically any positive 
integer from 0 to 50. 
    
    The underlying assumption here is that this is an option that's only going 
to be used by someone who knows what they're doing, most likely someone 
debugging the client. Users will generally use "--verbose-logging" instead of 
setting a specific value.
    
    Since this is an option that's going to show up in *every* command's help, 
I'd really like to keep it's helpline as concise as possible.
    
    How about adding "numeric level as defined by python standard logging"?


- Mark Chu-Carroll


On Oct. 15, 2014, 12:46 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26688/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 12:46 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: aurora-831
>     https://issues.apache.org/jira/browse/aurora-831
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Put plugin-generated options into the correct order.
> - Include the option-name in the detailed help list.
> - Add missing metavars.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8 
>   src/main/python/apache/aurora/client/cli/options.py 
> dc76c25b90acb9610e40b939e65c3cabf032649f 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 20f4d7ef43ba336a2b6d02cbf5656c97bdfa2ea1 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> f73c8a3778b7d118ea2865f213b442a607fb4a7d 
> 
> Diff: https://reviews.apache.org/r/26688/diff/
> 
> 
> Testing
> -------
> 
> New help output:
> {noformat}
> [sun-wukong incubator-aurora (deprecate)]$ ./dist/aurora2.pex help cron 
> deschedule
> Usage for verb "cron deschedule":
>   deschedule   [--verbose-logging]   [--logging-level=numeric_level]   
> [--error-log-dir=error-log-dir] [--bind=var=value] CLUSTER/ROLE/ENV/NAME
> Options:
>   --bind=var=value
>       Bind a pystachio variable name to a value. Multiple flags may be used 
> to specify multiple values.
>   CLUSTER/ROLE/ENV/NAME
>       Fully specified job key, in CLUSTER/ROLE/ENV/NAME format
>   --verbose-logging
>       Show verbose logging, including all logs up to level INFO (equivalent 
> to --logging-level=20)
>   --logging-level=numeric_level
>       Set logging to a specific numeric level.
>   --error-log-dir=error-log-dir
>       Directory location where error files containing stack traces should be 
> written. If the directory doesn't exist, it will be created
> 
> Remove the cron schedule for a job.
> {noformat}
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to