-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26845/#review57054
-----------------------------------------------------------


There's a lot of good stuff in here, but i'm concerned that this is more a 
developer's guide than a what's-what for operators.  For example, talking about 
APIs may not be useful.


docs/storage.md
<https://reviews.apache.org/r/26845/#comment97533>

    Consider using hashes for headers rather than underlines, easier to 
maintain:
    
    # Aurora Scheduler Storage



docs/storage.md
<https://reviews.apache.org/r/26845/#comment97529>

    s/a significant amount of //



docs/storage.md
<https://reviews.apache.org/r/26845/#comment97530>

    remove



docs/storage.md
<https://reviews.apache.org/r/26845/#comment97531>

    s/proprietary //



docs/storage.md
<https://reviews.apache.org/r/26845/#comment97534>

    s/approach //



docs/storage.md
<https://reviews.apache.org/r/26845/#comment97535>

    This is false!  The replicated log is a write-ahead log (in fact, you 
should link to http://en.wikipedia.org/wiki/Write-ahead_logging somewhere).
    
    In fact, maybe this section should be renamed "Write-ahead logging".



docs/storage.md
<https://reviews.apache.org/r/26845/#comment97537>

    s/Majority/The majority/
    
    s/H2 database operating in memory mode/in-memory H2 database/



docs/storage.md
<https://reviews.apache.org/r/26845/#comment97538>

    Consider removing the last sentence, i don't think it adds much.



docs/storage.md
<https://reviews.apache.org/r/26845/#comment97540>

    s/as/since/


- Bill Farner


On Oct. 16, 2014, 11:38 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26845/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 11:38 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-839
>     https://issues.apache.org/jira/browse/AURORA-839
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Created a high level storage architecture write up.
> 
> 
> Diffs
> -----
> 
>   docs/images/storage_hierarchy.png PRE-CREATION 
>   docs/storage.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26845/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/maxim111333/incubator-aurora/blob/storage_doc/docs/storage.md
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to