> On Oct. 16, 2014, 11:56 p.m., Bill Farner wrote:
> > There's a lot of good stuff in here, but i'm concerned that this is more a 
> > developer's guide than a what's-what for operators.  For example, talking 
> > about APIs may not be useful.

We totally lack any storage overview and I thought we have to start somewhere. 
The APIs are there just to illustrate the available consistency model.


> On Oct. 16, 2014, 11:56 p.m., Bill Farner wrote:
> > docs/storage.md, line 2
> > <https://reviews.apache.org/r/26845/diff/1/?file=723504#file723504line2>
> >
> >     Consider using hashes for headers rather than underlines, easier to 
> > maintain:
> >     
> >     # Aurora Scheduler Storage

Done.


> On Oct. 16, 2014, 11:56 p.m., Bill Farner wrote:
> > docs/storage.md, line 13
> > <https://reviews.apache.org/r/26845/diff/1/?file=723504#file723504line13>
> >
> >     s/a significant amount of //

Done.


> On Oct. 16, 2014, 11:56 p.m., Bill Farner wrote:
> > docs/storage.md, line 20
> > <https://reviews.apache.org/r/26845/diff/1/?file=723504#file723504line20>
> >
> >     remove

:) Done.


> On Oct. 16, 2014, 11:56 p.m., Bill Farner wrote:
> > docs/storage.md, line 22
> > <https://reviews.apache.org/r/26845/diff/1/?file=723504#file723504line22>
> >
> >     s/proprietary //

Done.


> On Oct. 16, 2014, 11:56 p.m., Bill Farner wrote:
> > docs/storage.md, line 23
> > <https://reviews.apache.org/r/26845/diff/1/?file=723504#file723504line23>
> >
> >     s/approach //

Done.


> On Oct. 16, 2014, 11:56 p.m., Bill Farner wrote:
> > docs/storage.md, line 51
> > <https://reviews.apache.org/r/26845/diff/1/?file=723504#file723504line51>
> >
> >     This is false!  The replicated log is a write-ahead log (in fact, you 
> > should link to http://en.wikipedia.org/wiki/Write-ahead_logging somewhere).
> >     
> >     In fact, maybe this section should be renamed "Write-ahead logging".

I don't know who wrote that :) Thanks for catching! Moved it into Atomicity 
section.


> On Oct. 16, 2014, 11:56 p.m., Bill Farner wrote:
> > docs/storage.md, line 60
> > <https://reviews.apache.org/r/26845/diff/1/?file=723504#file723504line60>
> >
> >     s/Majority/The majority/
> >     
> >     s/H2 database operating in memory mode/in-memory H2 database/

Done.


> On Oct. 16, 2014, 11:56 p.m., Bill Farner wrote:
> > docs/storage.md, line 61
> > <https://reviews.apache.org/r/26845/diff/1/?file=723504#file723504line61>
> >
> >     Consider removing the last sentence, i don't think it adds much.

I'd rather keep it as it partially justifies our choice of H2 over 
java-map-based solution.


> On Oct. 16, 2014, 11:56 p.m., Bill Farner wrote:
> > docs/storage.md, line 66
> > <https://reviews.apache.org/r/26845/diff/1/?file=723504#file723504line66>
> >
> >     s/as/since/

Done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26845/#review57054
-----------------------------------------------------------


On Oct. 16, 2014, 11:38 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26845/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 11:38 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-839
>     https://issues.apache.org/jira/browse/AURORA-839
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Created a high level storage architecture write up.
> 
> 
> Diffs
> -----
> 
>   docs/images/storage_hierarchy.png PRE-CREATION 
>   docs/storage.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26845/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/maxim111333/incubator-aurora/blob/storage_doc/docs/storage.md
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to